Repository navigation
core: glass-look - #918
core: glass-look#918
Conversation
Look gains wash_top/wash_bottom, sweep, ceiling, edge_dark and the lit-edge fields; Looks holds one per role (drop, text, card, bar, lens) and is published once a frame by core.material.publishLook. The glass program reads four more header vec4s; all four compiled forms regenerated. fizzy's defaults leave its pixels unchanged. Agent-Team: linux Worker: claude Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
PM note: how this PR will be handledWhat it is for: core: glass-look Rules that apply: none special. Things to watch (checked by rule):
What happens next:
A living status comment below is kept current. Nothing here is a merge decision. |
Where this PR standsStage: Author's turn What the PM needs before approving (ticks as it is met; the full CI runs only at the end, after the reviews are clean):
Reviews at the current commit (
2 earlier reviews are for older commits and will be redone. Latest fixes comment: https://github.com/fizzyedit/work/issues/492#issuecomment-6457353420 (4 findings answered) Updated 2026-10-28 06:11 UTC by the PM. This comment is edited in place. |
Agent-Team: linux Worker: codex
|
PM: released the stale reviewing:macos-* claim (the Mac has been offline since about 21:40Z, so that review cannot finish). Any other kind can review this head. |
Part of fizzyedit/work#421
Rework: work#502
Goal
Answer review findings on PR #918 at 246c753 (fizzyedit/work#502).
What changed and why
Remove unused step-3 lit-edge API and packing, reducing the shader header from 11 to 9 vectors; regenerate SPIR-V, DXIL, Metal and GLSL. Keep surface/window colour free of the look's sweep. Preserve already-published looks when the plain-app floating-window fallback runs off macOS. Add curve identity defaults and correct shared-data-id documentation.
How it was verified
The integration regression checks both surface and window sweep exclusion (fails before this fix) and independently pins the previous lift formula across 11 opacities and all five roles. Shader generation, format, lint and build/test gates are recorded in GATES.md. No GPU screenshot or tape was captured; the required identical drop-zone before/after pair remains outstanding.
Not done / follow-ups
Retain mix/lift for unpublished glass and surface/window-owned colour pending a cross-platform migration decision. Keep the single shared publication implementation used by core's alias and the standalone backend. FIXES.md answers every supplied finding; the harness supplies commit ids and publishes the response. Visual GPU verification remains outstanding.
Changes (81 files, +1369/-2823)
Gates: 6 of 6 passed
scripts/check-fmt.sh(exit 0)scripts/zb build --summary all(exit 0)scripts/zb build test --summary all(exit 0)scripts/zb build test-integration --summary all(exit 0)scripts/zb build check-web --summary all(exit 0)scripts/zb build test-sdk-version --summary all(exit 0)